Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thread/goroutine id #37

Merged
merged 7 commits into from
Jul 22, 2023
Merged

add thread/goroutine id #37

merged 7 commits into from
Jul 22, 2023

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Jul 20, 2023

Stealing the excellent https://github.com/kortschak/goroutine/ v1.0.1

Screenshot 2023-07-21 at 4 51 53 PM
  • check perf impact to decide to include or not by default
    • add newer benchmark/json case
    • plus compare with/without GoroutineID logging

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (15ffbdd) 100.00% compared to head (25afe17) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines          292       314   +22     
=========================================
+ Hits           292       314   +22     
Impacted Files Coverage Δ
console_logging.go 100.00% <100.00%> (ø)
goroutine/gid.go 100.00% <100.00%> (ø)
logger.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly merged commit 840b0d3 into main Jul 22, 2023
@ldemailly ldemailly deleted the thread_id branch July 22, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant